Skip to content

Lower min required Python version to 3.7 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Lower min required Python version to 3.7 #14

merged 5 commits into from
Aug 29, 2022

Conversation

donatasm
Copy link
Contributor

@donatasm donatasm commented Aug 24, 2022

Package could not be installed to Python 3.7 environments.

Lower the version to minimum supported, as stated in attach docstring.

@jarrodmillman jarrodmillman marked this pull request as draft August 25, 2022 13:55
@donatasm donatasm marked this pull request as ready for review August 28, 2022 18:41
@donatasm donatasm marked this pull request as draft August 28, 2022 18:42
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #14 (bf18fef) into main (eeb6a7d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files           4        4           
  Lines         174      174           
=======================================
  Hits          145      145           
  Misses         29       29           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jarrodmillman
Copy link
Member

@donatasm Thanks for the contribution! Before merging we should add 3.7 to the CI and classifiers. If you want to take care of it and see this soon, please:

  • add 3.7 to the classifiers in pyproject.toml
  • add 3.7 to the python-version in .github/workflows/test.yml
  • change args: [--py38-plus] to args: [--py37-plus] in .pre-commit-config.yaml

If you don't respond in an hour or so, I will just push to your branch. Once that is done (assuming the tests pass), I will merge.

I plan to release lazy_loader 0.1rc3 later today or tomorrow after doing a few other minor things.

@donatasm
Copy link
Contributor Author

@donatasm Thanks for the contribution! Before merging we should add 3.7 to the CI and classifiers. If you want to take care of it and see this soon, please:

  • add 3.7 to the classifiers in pyproject.toml
  • add 3.7 to the python-version in .github/workflows/test.yml
  • change args: [--py38-plus] to args: [--py37-plus] in .pre-commit-config.yaml

If you don't respond in an hour or so, I will just push to your branch. Once that is done (assuming the tests pass), I will merge.

I plan to release lazy_loader 0.1rc3 later today or tomorrow after doing a few other minor things.

@jarrodmillman thanks, I'll fix it now.

@donatasm
Copy link
Contributor Author

Done. All checks pass for Python 3.7! 🎉

@jarrodmillman jarrodmillman marked this pull request as ready for review August 29, 2022 08:20
@jarrodmillman jarrodmillman added this to the 0.1 milestone Aug 29, 2022
@jarrodmillman
Copy link
Member

Thanks!!

@jarrodmillman jarrodmillman merged commit d6593de into scientific-python:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants