Skip to content

ENH: only run diffed content #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −2
Draft

ENH: only run diffed content #49

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aacfb2b
ENH: only run diffed content
bsipocz May 13, 2025
3565257
Changing defaults to run on all notebooks
bsipocz May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ENH: only run diffed content
  • Loading branch information
@bsipocz
bsipocz committed May 21, 2025
commit aacfb2bc2e52d681007d35df1d055d63e9cd9ccb
11 changes: 9 additions & 2 deletions test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,17 @@ notebook_files=()

# Find Markdown files convert.
all_markdown_files=$(find tutorials -type f -name "*.md")

if [ $# -gt 0 ]; then
files_to_process="$@"
if [[ "$1" == all ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [[ "$1" == all ]]; then
if [[ "$1" == --all ]]; then

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make --all the default because it requires no further input for the user.

files_to_process=$all_markdown_files
else
files_to_process="$@"
fi

else
files_to_process=$all_markdown_files
# We only want to run tests for the notebooks we touched
files_to_process=$(git fetch origin main --depth=1; git diff origin/main --name-only tutorials | grep .md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the usage is --changed <branch> we can avoid hard-coding a specific branch name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, and the we can hard-code origin and main on CI as those are set up there.

fi

# Identify Markdown files that are Jupytext and convert them all.
Expand Down