Skip to content

Fix python_requires #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2024
Merged

Fix python_requires #5

merged 1 commit into from
Jun 22, 2024

Conversation

@OriolAbril
Copy link
Contributor

@OriolAbril OriolAbril commented Jun 21, 2024

Path.walk was introduced in python 3.12, and it is used in

docstub/src/docstub/_stubs.py

Line 37 in b8c453f

for root, _, files in root_dir.walk(top_down=True):
, which makes the library only work on python>=3.12

@OriolAbril OriolAbril mentioned this pull request Jun 21, 2024
Open
@lagru lagru merged commit a1b0e10 into scientific-python:main Jun 22, 2024
@lagru
Copy link
Member

lagru commented Jun 22, 2024

Thanks. :D

@OriolAbril OriolAbril deleted the patch-1 branch June 22, 2024 16:25
@lagru lagru added the maintenance Keeps the lights on label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance Keeps the lights on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OriolAbril @lagru