Attribute copyright to Scientific Python Developers #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
This is exactly what we did with doctestplus, but swapping the order, the newest/actual copyright is at the top, then history at the bottom. This one might look a bit weird as all the years are the same, but time will sort it all out on the long term :)
(code suggestion didn't work, so here it is:
Copyright (c) 2024, Scientific Python Developers
Copyright (c) 2024, Lars Grüter
|
You should leave your name! Just switch the order and this is ready to merge. |
as well instead of just "docstub developers".
|
Thanks for the feedback. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3 because I think all other things are addressed.
Is it okay to grant the additional copyright like I did here and keep the old one? In this case I'd be totally happy to remove the line with my name, but I'd find it a bit strange if we required tools with a longer history that move over to the Scientific Python umbrella to forsake their copyright (I think in some jurisdictions that isn't even possible)? If we require this, the docs definitely need some documentation around this expectation, as I'm myself a bit unclear on what this means, why it's necessary, and its consequences.