Fix grammar and allow plural "(s)" #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While lark didn't complain at all about this, leaving the first line after the ":" empty was matching "nothing". Obviously not what is intended! So while it would be more readable to be able to wrap everything inside a rule with an indent, it doesn't seem to be supported currently [1]. [1] www.github.com/lark-parser/lark/issues/155
Still not perfect, but the names and structure make a lot more sense to me now. This also allows using a plural "(s)" in "container of type" style expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an implicit match for "" (nothing) because I left the first line after the ":" empty. Obviously not what is intended! So while it would be more readable to be able to wrap everything inside a rule with an indent, it doesn't seem to be supported currently [1].
Also, allow appending
(s)to indicate plural in expressions likelist of int(s). A negative lookbehind regex disallows a space directly in front of(s).Other changes improve on naming, structure and tests.
[1] www.github.com/lark-parser/lark/issues/155