Collect docnames of analyzed source in advance #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lagru
changed the title
This syntax is used by Pandas [1]. I'm not entirely sold yet, but let's
add it for now. To avoid confusion, literals should probably be made to
only be accepted on the top-level. Otherwise something like
`dict of {{"a", "b"}: int}` becomes possible.
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
which avoids potentially confusing constructs like
`dict of {{"a", "b"}: int}`
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
since this is what NumPyDoc recommends as well [1]. [1] https://numpydoc.readthedocs.io/en/latest/format.html#parameters Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
Doing this on the NAME level meant that stuff like "np.int16" would be turned into "np.np.int16" because both "np" and "int16" where matched.
Reduce responsibility of the former DocName class. Replacing docstring specific type description should be handled separately.
While not perfect or anywhere near to finished the refactored code uses clearer separation of responsiblities and is one step closer to an architecture that feels right. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to be able to use names that are within scope of the current module or, alternatively, from the same package scope with
~.SomeName.