Fix all clippy and rustc warnings (beta toolchain version 0.1.77) #345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
suspicious_open_options
lint 0 warns that the truncation behaviour should be made explicit when creating new files. We also setcreate_new(true)
, which ensures that a new file will always be created so we should simply dropcreate(true)
since it has no effect anyway: "If.create_new(true)
is set,.create()
and.truncate()
are ignored." 1The
unconditional_recursion
lint 2 also emits a warning but that's a false positive and should already be fixed in nightly (see 3 for a very similar case and 4 for the PR that should fix it). In our case we're comparing tuples with just two fields of thePackage
structure so it isn't recursive.This fixes the following clippy warnings: