Corrige erros na obtenção de parágrafos da base isis (nome de função e xpath de ativos digitais) #115
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR corrects a function name from avoid_mismatched_p to avoid_mismatched_tags in the ISIS database paragraph retrieval code. The change reflects that the function handles mismatched HTML tags in general, not just paragraph tags specifically.
- Updates function calls in
fix_paragraphs()andfix_references()to use the correctly named function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| old_link = change.get("old_link") | ||
| new_link = change.get("new_link") | ||
| for node in self.tree.xpath(f".//a[@href={old_link}]|.//img[@src={old_link}]"): | ||
| for node in self.tree.xpath(f'.//a[@href="{old_link}"]|.//img[@src="{old_link}"]'): |
There was a problem hiding this comment.
XPath injection vulnerability: old_link is directly interpolated into the XPath expression without sanitization. If old_link contains double quotes or special XPath characters, it could break the query or allow injection. Use XPath variables or sanitize the input by escaping special characters.
| for node in self.tree.xpath(f'.//a[@href="{old_link}"]|.//img[@src="{old_link}"]'): | |
| for node in self.tree.xpath('.//a[@href=$old_link]|.//img[@src=$old_link]', old_link=old_link): |
robertatakenaka
changed the title
1 participant
No description provided.