Skip to content

[Snyk] Security upgrade django from 1.11.29 to 4.2.28 #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertatakenaka wants to merge 1 commit into
base: beta
Choose a base branch
from
Open

[Snyk] Security upgrade django from 1.11.29 to 4.2.28 #1489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ django-debug-toolbar
coverage
django-coverage
Fabric==1.4.3
django>=4.2.28 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency name casing is inconsistent with the rest of this repo: requirements.txt uses Django (capitalized) while this adds django. Pip treats names case-insensitively, but keeping casing consistent reduces diff churn and tooling inconsistencies (e.g., grep/audit scripts).

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn’t match the PR description (“upgrade django from 1.11.29 to 4.2.28” to fix a vulnerability): the repo’s declared Django requirement is currently Django<1.5 (requirements.txt:1), and the new constraint is only added to requirements-dev.txt. If the vulnerability is relevant to runtime, it won’t be addressed by a dev-only dependency; if it’s dev-only, the project’s Django constraint/version should be clarified so dependency scanning results are consistent.

Copilot uses AI. Check for mistakes.