Feat: build person group element #734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| def build_person_group(data): | ||
| for person_group_type in ("author", "compiler"): |
There was a problem hiding this comment.
@Rossi-Luciano melhor não restringir, não validar. Assuma o valor passado como person_group_type independente do valor.
There was a problem hiding this comment.
OK, @robertatakenaka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Adiciona função para gerar o elemento
person-groupno formato xml.Onde a revisão poderia começar?
Por commit.
Como este poderia ser testado manualmente?
Sugiro avaliar os testes:
python3 -m unittest -v tests/sps/formats/sps_xml/test_person_group.pyAlgum cenário de contexto que queira dar?
NA.
Screenshots
NA.
Quais são tickets relevantes?
NA.
Referências
NA.