Adiciona formato articlemeta para Journal e Issue #1039
Conversation
- fix get_next_journal_title and get_previous_journal_title
| return dict_a | ||
|
|
||
| def _format_journal_history(self): | ||
| journal_history = self.scielo_journal.journal_history.all() |
There was a problem hiding this comment.
Quando self.scielo_journal é None, ocorre AttributeError.
| "issn_print", | ||
| "issn_electronic", | ||
| "issn_electronic", | ||
| "issn", |
There was a problem hiding this comment.
@samuelveigarangel existe o campo issn (não seria issnl)?
There was a problem hiding this comment.
Na api articlemeta, há o paramentro issn, que faz a busca tanto em issn_print quanto issn_electronic.
issue/formats/articlemeta_format.py
Outdated
| if self.journal.official and self.journal.official.iso_short_title: | ||
| add_to_result("v151", self.journal.official.iso_short_title, self.result['issue']) | ||
|
|
||
| if self.journal.official and hasattr(self.journal.official, 'parallel_titles'): |
There was a problem hiding this comment.
@samuelveigarangel por que tem que ser testado desta forma hasattr(self.journal.official, 'parallel_titles')?
|
|
||
| def _format_title_in_database(self): | ||
| medline_data = self.medline_titles | ||
| add_items("v421", [medline.title for medline in medline_data], self.result['issue']) |
There was a problem hiding this comment.
Se medline_data for None, ele não adiciona achave. add_items faz essa verificação
| def _format_metadata(self): | ||
| """Metadados e relacionamentos""" | ||
| key_to_code = { | ||
| "publication_date": self.obj.year, |
There was a problem hiding this comment.
@samuelveigarangel não há casos de data completa ou pelo menos mes(es)?
|
|
||
| def _format_supplement_info(self): | ||
| """Informações de suplemento""" | ||
| if not self.obj.number: |
There was a problem hiding this comment.
@samuelveigarangel adicionar somente se há self.obj.supplement
3 participants
O que esse PR faz?
Adiciona Suporte ao Formato articlemeta
Onde a revisão poderia começar?
pelos commits
Como este poderia ser testado manualmente?
Acessar API de issue: http://0.0.0.0:8009/api/v1/issue/?formats=articlemeta
Acessar API de Journal: http://0.0.0.0:8009/api/v1/journal/?formats=articlemeta
paramentros de issue:
"collection", "from_publication_year", "until_publication_year", "from_date_created", "until_date_created", "from_date_updated", "until_date_updated", "issn_print", "issn_electronic", "issn", "volume", "number", "supplement", "formats", "code",paramentros de journal:
"issn_print", "issn_electronic", "issn", "title", "thematic_areas", "toc_item", "collection", "from_date_created", "until_date_created", "from_date_updated", "until_date_updated", "formats", "issnl",Algum cenário de contexto que queira dar?
N/A
Screenshots
Quais são tickets relevantes?
CLOSED #903
CLOSED #902
Referências
N/A