Fixes minor issues with Gemini Code Review in the JSON section

[gsnw-sebast]

Fixes minor issues with Gemini Code Review in the JSON section from pull request #409.

[gemini-code-assist]

Summary of Changes

Hello @gsnw-sebast, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the JSON output generated by the fping utility and updating its corresponding test cases. The primary change involves ensuring that JSON warning messages are properly terminated with a newline character, which improves the parsability of the output when consumed as a stream. The associated Perl tests have been adjusted to accurately validate this new output format, along with a minor fix to another JSON output regex.

Highlights

• JSON Output Formatting: A newline character (\n) has been appended to the JSON warning message printed to standard output when json_flag is enabled and an invalid host is encountered. This ensures that each JSON object is terminated with a newline, which is crucial for stream processing of JSON data.
• Test Suite Updates: The Perl test suite (ci/test-16-json-output.pl) has been updated to reflect the change in JSON output. Specifically, the regular expression matching the warning JSON output now expects a trailing newline character. Additionally, a minor correction was made to the vSum regex to properly escape a brace.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses minor issues related to JSON output. It correctly adds a newline to the warning message for invalid hosts and updates the corresponding test. It also fixes a typo in a regular expression within another test. However, I've identified an issue where one of the test's regular expressions still doesn't correctly match the program's output, as it's missing a newline separator between JSON objects. I've included a suggestion to resolve this.

[coveralls]

coverage: 86.235%. remained the same
when pulling a4fca24 on gsnw:fix-gemini-code-review-pr409
into e1bbe1e on schweikert:develop.