disable UIToolbarContentView every time one is created in layoutSubviews #2
Conversation
Source/SLKTextInputbar.m
Outdated
| } | ||
| } | ||
| toolbarContentViewEnabled = NO; | ||
| UIView *lastView = [self.subviews lastObject]; |
There was a problem hiding this comment.
How do we know that the last object will always be _UIToolbarContentView?
There was a problem hiding this comment.
I actually can't find much documentation on how _UIToolbarContentView is added (so I can't say 100% that this will always be last) - however, it always appears last when setting a breakpoint. Multiple solutions found online to this bug all check for _UIToolbarContentView as the last object. Additionally, self.subviews have all other views in init, but a _UIToolbarContentView is added in layoutSubviews. I'm assuming there are no other views added afterwards
There was a problem hiding this comment.
Hmm can you do a backwards loop and place the conditional inside? If the _UIToolbarContentView is found we can early terminate and if it's not it'll still loop through and find it. This way in case anything changes it'll work no matter what.
2 participants
A new UIToolbarContentView is added during layoutSubviews each time. When users reload the view, the newly created UIToolbarContentView requires disabling again. This pull request takes away the local static variable toolbarContentViewEnabled, since a check is required each time. It also only checks if the last subview is of class _UIToolbarContentView since the UIToolbarContentView is always added last.