Skip to content

Conversation

@schultek
Copy link
Owner

@schultek schultek commented Dec 15, 2025

Description

Resolves #701

Type of Change

Ready Checklist

  • I've read the Contribution Guide.
  • In case this PR changes one of the core packages, I've modified the respective CHANGELOG.md file using
    the semantic_changelog format.
  • I updated/added relevant documentation (doc comments with ///).
  • I added myself to the AUTHORS file (optional, if you want to).

@docs-page
Copy link

docs-page bot commented Dec 15, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/schultek/jaspr~702

Documentation is deployed and generated using docs.page.

@github-actions
Copy link

Package Version Report

The following packages have been updated:
jaspr_serverpod : 0.6.0 -> 0.7.0

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.96%. Comparing base (a588346) to head (5de14d2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...uilder/lib/src/options/client_options_builder.dart 0.00% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   60.01%   59.96%   -0.05%     
==========================================
  Files         194      194              
  Lines       10915    10924       +9     
==========================================
  Hits         6551     6551              
- Misses       4364     4373       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gonft added a commit to gonft/jaspr that referenced this pull request Dec 18, 2025
Refactored jaspr_serverpod to follow upstream PR schultek#702 approach:

- Remove explicit Relic dependency (handled internally by Serverpod 3.0)
- Delete shelf_relic_adapter.dart (95 lines) - use inline conversion
- Update JasprRoute to use serverpod.Request instead of relic.Request
- Add HijackException handling for WebSocket support
- Simplify Response creation with direct Serverpod types
- Update version to 0.7.0

BREAKING CHANGES:
- JasprRoute.build() now takes serverpod.Request (not relic.Request)
- Must hide Request, Response, Handler from jaspr/server.dart import
- Route path changed from /* to /**
- Removed toShelfRequest/toRelicResponse adapters

Migration:
- Update imports: hide Request, Response, Handler from jaspr/server
- Import serverpod types from package:serverpod/serverpod.dart
- Update dependent packages to jaspr_serverpod ^0.7.0
- Remove explicit relic dependency

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
@schultek schultek marked this pull request as ready for review December 18, 2025 10:57
@gazialankus
Copy link

I would love to see this merged. I would like to to use jaspr on our serverpod 3 app at some point.

There's a very simple ./pubspec.lock conflict: dart_style's version became 3.1.3 in main. Other than that I think this needs a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Serverpod 3.0 Relic web server support for jaspr_serverpod

3 participants