set status.observedGeneration after reconcile

[hensur]

Hey!

I've been testing your extension for a few days. After a cluster reconfiguration, gardener complained about the DNSRecords not being reconciled. However, they were successfully updated.

After manually updating status.observedGeneration to the current resource generation, the gardener reconciliation continued.

I'm not sure if that's supposed to be done by the gardener extension framework. I didn't see anything after taking a quick look at the provided methods.

I guess patching the status in the Reconcile method should work fine as well...

The expected behaviour regarding observedGeneration is explained here:
https://github.com/gardener/gardener/blob/master/docs/proposals/01-extensibility.md#custom-resource-definitions

[schrodit]

Sry for the late reply. Must have missed it in my notifications.

I don't think this is needed. The gardener extension runtime already sets the observed generation in the status updater if the operation is finished. See the dnsrecord reconciler.
So I think there there must be a different error as its also working fine in our productive setup with Gardener 1.56.2

Updater:

• Success: https://github.com/gardener/gardener/blob/v1.56.2/extensions/pkg/controller/status.go#L211
• Error: https://github.com/gardener/gardener/blob/v1.56.2/extensions/pkg/controller/status.go#L173