set status.observedGeneration after reconcile #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I've been testing your extension for a few days. After a cluster reconfiguration, gardener complained about the
DNSRecords
not being reconciled. However, they were successfully updated.After manually updating
status.observedGeneration
to the current resource generation, the gardener reconciliation continued.I'm not sure if that's supposed to be done by the gardener extension framework. I didn't see anything after taking a quick look at the provided methods.
I guess patching the status in the
Reconcile
method should work fine as well...The expected behaviour regarding
observedGeneration
is explained here:https://github.com/gardener/gardener/blob/master/docs/proposals/01-extensibility.md#custom-resource-definitions