Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the boost::iostreams dependency optional #80

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ptosco
Copy link
Contributor

@ptosco ptosco commented Dec 29, 2024

This small PR makes the boost::iostreams dependency optional, such that RDKit can still be built on Windows (MSVC) with CoordGen support without linking to boost::iostreams (e.g., when building CFFI with limited dependencies).
Currently it is possible to build CFFI with CoordGen support with g++ and clang++ as boost::iostreams defines its symbols as weak symbols, but not with MSVC as it does not understand weak symbols.

@ptosco
Copy link
Contributor Author

ptosco commented Jan 6, 2025

@ricrogz @d-b-w Hi both, could one of you take a look at this and merge if you think it makes sense? Thank you very much in advance!

Copy link
Collaborator

@ricrogz ricrogz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@d-b-w d-b-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ricrogz ricrogz merged commit d04fa00 into schrodinger:master Jan 8, 2025
@ptosco
Copy link
Contributor Author

ptosco commented Jan 8, 2025

@ricrogz @d-b-w Thank you very much!

@ptosco
Copy link
Contributor Author

ptosco commented Feb 23, 2025

@ricrogz @d-b-w Would you consider cutting a new maeparser 1.3.2 release with this small change? I have just verified that indeed it is now possible to build RDKit MinimalLib without boost::iostreams dependency but with maeparser and coordgen under Windows with this small change, while with 1.3.1 it fails.

@ptosco
Copy link
Contributor Author

ptosco commented Mar 4, 2025

@ricrogz @d-b-w Apologies for stalking you - Would you consider issuing a new maeparser 1.3.2 release incorporating the small change in this PR? That would enable building RDKit MinimalLib without boost::iostreams dependency but with maeparser and coordgen under Windows.
Could you please let me know? If you are not planning a new release just for this change, I will add a patch on the RDKit side.
Many thanks in advance for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants