Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated property name parsing procedure to allow colons #78

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

whosayn
Copy link
Contributor

@whosayn whosayn commented Jan 23, 2023

This change fixes a bug that triggered a read_exception when a ':' character was found in a valid property name.

Issue #77

Copy link
Collaborator

@ricrogz ricrogz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whosayn whosayn force-pushed the colon_in_prop_name_bugfix branch from b83f1d9 to 1298026 Compare January 24, 2023 18:29
This change fixes a bug that triggered a read_exception when a ':'
character was found in a valid property name.

Issue schrodinger#77
@whosayn whosayn force-pushed the colon_in_prop_name_bugfix branch from 1298026 to 4900e55 Compare January 24, 2023 20:16
Copy link
Collaborator

@d-b-w d-b-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@d-b-w d-b-w merged commit ce35179 into schrodinger:master Jan 24, 2023
@whosayn whosayn deleted the colon_in_prop_name_bugfix branch January 24, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants