modifications to get maeparser building with C++20 #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-is, maeparser will not compile with g++ using
-std=gnu++20
becauseMaeBlock.hpp
has some constructors and destructors which include explicit template information. I'm not sure this was ever required, but it's no longer allowed in C++20.Here's a stack overflow post with some more details: https://stackoverflow.com/questions/63513984/can-class-template-constructors-have-a-redundant-template-parameter-list-in-c2
The fix is easy and shouldn't affect anything when using older versions of the C++ standard (I've tested back to C++11).
I found this because the RDKit had some of the same fun in it that needed to be cleaned up.