Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifications to get maeparser building with C++20 #76

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

greglandrum
Copy link
Collaborator

As-is, maeparser will not compile with g++ using -std=gnu++20 because MaeBlock.hpp has some constructors and destructors which include explicit template information. I'm not sure this was ever required, but it's no longer allowed in C++20.
Here's a stack overflow post with some more details: https://stackoverflow.com/questions/63513984/can-class-template-constructors-have-a-redundant-template-parameter-list-in-c2

The fix is easy and shouldn't affect anything when using older versions of the C++ standard (I've tested back to C++11).

I found this because the RDKit had some of the same fun in it that needed to be cleaned up.

@ricrogz
Copy link
Collaborator

ricrogz commented Feb 1, 2023

I merged master into the branch to trigger a build. But I didn't expect my push to go to your repo, @greglandrum. In fact, I didn't expect I'd be allowed to push to your repo!

@d-b-w d-b-w merged commit f094cb5 into schrodinger:master Feb 1, 2023
@greglandrum greglandrum deleted the dev/cpp20_compatibility branch October 25, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants