Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added methods to get names of sub-blocks in mae::Block #75

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Added methods to get names of sub-blocks in mae::Block #75

merged 2 commits into from
Aug 11, 2022

Conversation

rachelnwalker
Copy link
Contributor

This is helpful for reading other blocks in our MaeParserReader.

ricrogz
ricrogz approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@ricrogz ricrogz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

d-b-w
d-b-w requested changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@d-b-w d-b-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after removing the extra include

@d-b-w d-b-w merged commit 8a449ad into schrodinger:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-b-w d-b-w d-b-w requested changes

@ricrogz ricrogz ricrogz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachelnwalker @d-b-w @ricrogz