Add visibility attribute to import declaration #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-b-w
approved these changes
Jan 20, 2021
| @@ -15,7 +15,7 @@ | |||
| #ifdef WIN32 | |||
| #define EXPORT_MAEPARSER __declspec(dllimport) | |||
| #else | |||
| #define EXPORT_MAEPARSER | |||
| #define EXPORT_MAEPARSER __attribute__((visibility("default"))) | |||
There was a problem hiding this comment.
mind reordering so that it's
#ifdef WIN32
#ifdef IN_MAEPARSER
#define EXPORT_MAEPARSER __declspec(dllexport)
#else
#define EXPORT_MAEPARSER __declspec(dllimport)
#endif
#else
#define EXPORT_MAEPARSER __attribute__((visibility("default")))
#endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, clang doesn't correctly handle type comparisons with mismatched visibility: even if a library is compiled with default visibility, if the code linking it compiles using "hidden" visibility, types won't be correctly matched, creating problems at least in catching exceptions.
This is better explained in the last few comments in rdkit/rdkit/issues/2753. There are also some links to a proof of concept I built to demonstrate the problem with the RDKit.