Apply Clang tidy modernize & performance #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-b-w
reviewed
Apr 14, 2020
ricrogz
force-pushed
the
clang-tidy_modernize
branch
from
ffe8121 to
83e930a
Compare
|
Updated. I reran clang-tidy, and it seems stable. Also, I noticed the build failure in appveyor -- it looks like we use VS 12, and it doesn't understand |
|
Also, Travis is not running anymore ? |
d-b-w
approved these changes
Apr 17, 2020
| @@ -69,9 +70,9 @@ class EXPORT_MAEPARSER IndexedBlockMap : public IndexedBlockMapI | |||
| * Add an IndexedBlock to the map. | |||
| */ | |||
| void addIndexedBlock(const std::string& name, | |||
| std::shared_ptr<IndexedBlock> indexed_block) | |||
| std::shared_ptr<IndexedBlock>&& indexed_block) | |||
MaeParser.hpp
Outdated
| @@ -87,7 +88,7 @@ class EXPORT_MAEPARSER read_exception : public std::exception | |||
| format(line_number, column, msg); | |||
| } | |||
|
|
|||
| virtual const char* what() const throw() { return m_msg; } | |||
| const char* what() const noexcept override { return m_msg; } | |||
There was a problem hiding this comment.
yeah, I think you'll need to #iffdef around this. Or move the noexcept for now.
There was a problem hiding this comment.
Solved. I also removed a couple of spurious semicolons.
|
Thanks, Ricardo! |
d-b-w
added a commit
that referenced
this pull request
Apr 24, 2020
Avoid rvalue reference and move for compatibility (#61)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just what the title says. I did (each in one commit):
clang-tidy -fix -checks='modernize*,-modernize-use-trailing-return-type' *pp -- -std=c++11(no manual editing).public:blocks.clang-tidy -fix -checks='performance*,-modernize-use-trailing-return-type' *pp -- -std=c++11(no manual editing).clang-tidy was used from LLVM version 9.0.1. I disabled the "modernize-use-trailing-return-type" because it is annoying (changes function declarations to something like
auto whatever() -> return type. I also find it slightly annoying that clang-tidy insists on adding#include <utility>to the headers, but decided not to remove it.Checks passed on all three platforms (after bumping MacOS version): https://dev.azure.com/ricrogz/mymaeparser/_build/results?buildId=471