Skip to content

Added support to fix columns to the right side of the table. #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2017

Conversation

garytang8
Copy link
Contributor

@garytang8 garytang8 commented Oct 26, 2017

Description

Allow columns to be fixed to the right side of the table. This will enable a new fixedRight prop on the Column components. I have also added a new example for a table with columns fixed to the right.

Motivation and Context

This will resolve this issue: #121

How Has This Been Tested?

I created a new example with two columns set to have fixedRight to be true and it rendered as expected. I also checked out the other examples and they appear to render correctly as well. In addition to this, I executed npm run test and all tests passed.

Screenshots (if appropriate):

screenshot-fixed-right-columns

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@garytang8
Copy link
Contributor Author

@wcjordan I would update the documentation for the ColumnAPI to reflect the new prop, but noticed that the 'docs/api' folder is ignored. Is there a more appropriate way to change the docs?

@wcjordan
Copy link
Member

The docs are autogenerated, so you should add the prop to FixedDataTableColumn.js and it will update to appear in the documentation.

This looks good from my end, I'll try it out some and merge this weekend.

@garytang8
Copy link
Contributor Author

Nice! That reminded me to add in the prop type. So I guess I can check off the documentation task now. Thanks for looking at this!

@wcjordan
Copy link
Member

Great, I'll merge and cut a release. Thanks so much for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants