try to get stderr width if stdout is not a terminal #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
thanks! looks great |
WGH-
added a commit
to WGH-/progressbar
that referenced
this pull request
Feb 7, 2025
Instead of always checking stdout, check the actually configured output file. Fixes cases when stdout is redirected to a file or /dev/null, but stderr remains connected to the terminal. It was previously fixed in schollz#91, but was broken in schollz#156.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the progressbar writing to stderr, when redirecting stdout to a file, the progressbar wasn't stretching to the whole line, limited at 80 columns.