Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore version byte for compressed SWFs #31

Closed
schnaader opened this issue Mar 21, 2016 · 0 comments
Closed

Ignore version byte for compressed SWFs #31

schnaader opened this issue Mar 21, 2016 · 0 comments
Assignees

Comments

@schnaader
Copy link
Owner

Compressed SWF files contain a version byte. At the moment, it is checked if this version byte is between 0 and 10:

if ((swf_version > 0) && (swf_version < 10)) {

Unfortunately, the highest possible SWF version is 32 as of Mar 10, 2016 (list at Adobe, StackOverflow question) and it's very likely to proceed further.

As the 3 preceding bytes (CWS) don't leave too much room for false positives, the best solution is to just ignore the version flag.

schnaader added a commit that referenced this issue Mar 21, 2016
@schnaader schnaader added this to the Precomp v0.4.5 milestone Mar 21, 2016
@schnaader schnaader self-assigned this Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant