[WIP] Apply Doctrine CS #968
Conversation
|
| */ | ||
| public function dispatch($eventName, string $class, string $format, Event $event): void; | ||
| public function dispatch(string $eventName, string $class, string $format, Event $event): void; |
There was a problem hiding this comment.
good catch, this is a bug! :)
There was a problem hiding this comment.
There is more of missing types, some break more things so I would probably not touch types in first iteration and do them separately, then add proper docblocks for properties etc. (this one is especially in extremely bad shape in Serializer).
Then we can also consider PHPStan.
yes
It's totally useless and very often outdated, Git already provides more accurate information. |
|
Also please decide the following:
|
|
How to run the comment to apply the rules? is it documented somewhere? |
|
Since the project has (would)
|
|
will try, tnx! |
|
implemented in #971 |
Initial import of Doctrine CS.
@goetas Excluded some rules you mentioned before that you don't like.
Also excluded BC-breaking rules since the code base is currently a bit messy, a lot of inconsistent/missing parameter/return types. :(
Only applied to src/ to give you some look at the result, and to have something to discuss/improve later on.