Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed usage of deprecated AbstractNodeVisitor #587

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

grossmannmartin
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets
License Apache2

Description

Using Twig\NodeVisitor\AbstractNodeVisitor is deprecated. This PR removes the usage of the AbstractNodeVisitor class and replaces it with implementing the NodeVisitorInterface.
The support for Twig v1.X was dropped to do it safely.

Todos

  • Tests - not necessary to add new tests
  • Documentation - unchanged
  • Changelog

@goetas goetas merged commit 90d26b3 into schmittjoh:master Jun 8, 2024
17 checks passed
@goetas
Copy link
Collaborator

goetas commented Jun 8, 2024

thanks

@grossmannmartin grossmannmartin deleted the mg-nodevisitor branch June 9, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants