Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent type error on choices array with optional keys #585

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

qkdreyer
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License Apache2

Description

TypeError: Cannot assign null to property PhpParser\Node\ArrayItem::$value of type PhpParser\Node\Expr

@qkdreyer
Copy link
Contributor Author

qkdreyer commented Mar 7, 2024

@goetas hey! could be get this merged too?

@goetas goetas merged commit 97bb596 into schmittjoh:master Mar 11, 2024
17 checks passed
@goetas
Copy link
Collaborator

goetas commented Mar 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants