Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade nikic/php-parser@^5 #584

Merged
merged 1 commit into from
Feb 6, 2024
Merged

chore(deps): upgrade nikic/php-parser@^5 #584

merged 1 commit into from
Feb 6, 2024

Conversation

qkdreyer
Copy link
Contributor

@qkdreyer qkdreyer commented Jan 8, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License Apache2

Description

Upgrade nikic/php-parser@^5 for phpunit-bridge compatibility

Todos

  • Tests
  • Documentation
  • Changelog

@qkdreyer
Copy link
Contributor Author

qkdreyer commented Jan 8, 2024

https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-5.0.md

goetas
goetas reviewed Jan 8, 2024
View reviewed changes
composer.json Show resolved Hide resolved
@qkdreyer qkdreyer requested a review from goetas January 8, 2024 15:02
@qkdreyer
Copy link
Contributor Author

bump @goetas

@qkdreyer
Copy link
Contributor Author

👋

@qkdreyer
Copy link
Contributor Author

qkdreyer commented Feb 6, 2024

any news? 😞

@goetas goetas merged commit ad89a56 into schmittjoh:master Feb 6, 2024
17 checks passed
@qkdreyer qkdreyer deleted the nikic-php-parser-5 branch February 8, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetas goetas Awaiting requested review from goetas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qkdreyer @goetas