New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #437 #452

Open

evertharmeling wants to merge 1 commit into schmittjoh:master from evertharmeling:master

evertharmeling commented Aug 7, 2017

see #437


          Fixed schmittjoh#437

b30911c

Collaborator

gnat42 commented Aug 8, 2017

This looks like a slam dunk - I'm wondering 2 things however.

Can you include as part of this a test case that fails when this isn't applied
Do you know what instance $item->value would need to be to have getDocComment? We could still hit the same issue if we call that method and it isn't an instance of whatever it needs to be to have that method? Or is it guaranteed to have that method?
If you can do those two things I'd be happy to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet