Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid asking for permissions twice #213

Closed
wants to merge 1 commit into from

Conversation

optout21
Copy link

@optout21 optout21 commented May 7, 2019

See #110

No permission asked during getCameras(), option to skip _ensureAccess().

@kidanam
Copy link

kidanam commented Jun 23, 2019

Does this work? how do I use this new change?

@optout21
Copy link
Author

Yes, double call is avoided with this proposed change. I believe it solves the problems reported in issue #110 .

@Maxwellkurt0407
Copy link

See #110

No permission asked during getCameras(), option to skip _ensureAccess().

How do I use this in the browser?

@optout21
Copy link
Author

optout21 commented Jul 7, 2020

How do I use this in the browser?

What do you mean? How to use instascan in a browser? It is HTML/web based.

@Maxwellkurt0407
Copy link

How do I use this in the browser?

What do you mean? How to use instascan in a browser? It is HTML/web based.

Amateur developer here, I apologize. I mean, how do I include the changes in the instascan.min.js file? Is there a way to do that?

@optout21
Copy link
Author

optout21 commented Jul 9, 2020

To integrate the changes for trying out? Since there are only 2-3 lines changed, you can just look at Files Changed, and copy the changes. Or you can checkout the branch of the pr:

git remote add mikroncoin https://github.com/mikroncoin/instascan.git
git fetch mikroncoin
git checkout -b pr/213 -t mikroncoin/no-double-perm

To take over the changes for good, you just Merge the PR :)

@optout21
Copy link
Author

Closing after 4+ years

@optout21 optout21 closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants