Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix visible scrollbar in firefox #241

Closed
wants to merge 1 commit into from
Closed

Conversation

ueen
Copy link

@ueen ueen commented Jan 12, 2024

@@ -120,6 +120,7 @@ html {
display: flex;
align-items: center;
justify-content: center;
scrollbar-width: none;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the issue you state the following:

its part of the div with id=center

But the css selector you used is for elements with class=center.
Are you sure this is correct and does indeed fix your issue? As I cannot reproduce the issue I am dependent on your testing!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, are you sure this is sufficient? Is the issue specific to Firefox on MacOS or have you successfully reproduced it on any other Browser or OS? If so, we would need to add the following (according to your w3school link):

/* Hide scrollbar for Chrome, Safari and Opera */
.example::-webkit-scrollbar {
  display: none;
}

Where .example must be replaced by the correct selector.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other elements that use the center class? Did not see it in Safari :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class center is used to center its element via flexbox. The div with id center is not centered so it does not have the class center.

Please test whether your code works by adding it to the #center selector

@ueen
Copy link
Author

ueen commented Jan 23, 2024

#251

@ueen ueen closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Grey line on the right
2 participants