Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] sharing photos from the gallery not working on ios #336

Open
dm82m opened this issue Sep 19, 2024 · 12 comments · May be fixed by #350
Open

[Bug] sharing photos from the gallery not working on ios #336

dm82m opened this issue Sep 19, 2024 · 12 comments · May be fixed by #350
Labels
bug Something isn't working transfer

Comments

@dm82m
Copy link

dm82m commented Sep 19, 2024

Describe the bug
It is currently not possible to send files from the photos gallery. If you pick them, the browser reloads on the iphone and nothing is transferred. Transfer is working if you capture a photo in the dialog or send a file attachment.

To Reproduce
Steps to reproduce the behavior:

  1. Click on the device on your iOS
  2. Choose "Photogallery"
  3. Select an image and try to send it
  4. "Preparation running..."
  5. "This Website was reloaded due to a problem."

Expected behavior
Sending of photos from the gallery of the iPhone is working.

Screenshots
No real screenshots available.

Desktop (please complete the following information):

  • OS: MacOS 15
  • Browser chrome and safari -> both browsers same result!
  • Version up2date on both

Smartphone (please complete the following information):

  • Device: iPhone15
  • OS: iOS 18
  • Browser stock browser, safari but also same result with current Chrome browser
  • Version up2date

Bug occurs on official PairDrop instance https://pairdrop.net/
Yes
Version: v1.10.10

@dm82m dm82m added the bug Something isn't working label Sep 19, 2024
@schlagmichdoch
Copy link
Owner

Thanks for your report! As I cannot reproduce this on an iOS 17 iPhone I need some more info:

  • Has this only happened since you updated your iPhone to iOS 18?
  • Is it possible to send images with this shortcut: https://routinehub.co/shortcut/13990/
  • How big is the photo you are trying to send?
  • Have you tried different types of photos? Screenshots vs. camera shots vs. videos etc.?
  • If this is only present in some photos, would you be able to send me a copy of it via mail or drive link? (sonnig-02.hieven@icloud.com)

@dm82m
Copy link
Author

dm82m commented Sep 19, 2024

  • Has this only happened since you updated your iPhone to iOS 18?

I am new to PairDrop, haven't tested it before iOS 18 and I have no iOS < 18 device at hand

yes its possible, but it is converting heic to jpg; so no option for me as I want to transfer original files

  • How big is the photo you are trying to send?

1.4MB

  • Have you tried different types of photos? Screenshots vs. camera shots vs. videos etc.?

Problem occurs with .heic files, .jpg are working without an issue

  • If this is only present in some photos, would you be able to send me a copy of it via mail or drive link? (sonnig-02.hieven@icloud.com)

I sent you one of the images where the transfer is not working

fun fact: using snapdrop.net and its working; but honestly I would prefer to work with pairdrop.net, that's why I created the issue here... ;-)

@schlagmichdoch
Copy link
Owner

Thanks for the infos and quick response! I can reproduce this now, when I share heic images as original instead of „most compatible“.

Apparently, the library used to create thumbnails of heic images is broken and the error is not handled properly. The library seems to crash with some photos only but I’m not sure yet what’s the issue. Here’s a demo page for testing: https://alexcorvi.github.io/heic2any/#try.

I’m short of time atm but I’ll take a look into it and will fix this soon together with #332.

@schlagmichdoch
Copy link
Owner

schlagmichdoch commented Sep 24, 2024

@dm82m I've just tried again and somehow the problem is not reproducible anymore for me with any photo including yours. Is this still an issue for you?

@dm82m
Copy link
Author

dm82m commented Sep 24, 2024

yes it still occurs. I tested it with a new image created today, just 2mb in size and it worked. but as soon as I take heic images that are ~4mb in size, the issue occurs. also with the image I have sent you by mail.

@dm82m
Copy link
Author

dm82m commented Oct 7, 2024

Any progress here?

@schlagmichdoch
Copy link
Owner

I‘m currently on vacation so I’m afraid it will be another week until this is fixed in PairDrop.

Apparently, this is due to the library libheif that is used by the heic2any package that we use. It has since been resolved in libheif but heic2any is not updated yet.
alexcorvi/heic2any#61

In that issue you’ll also find a list of devices that are affected by this.

I guess I’ll fast-forward the changes myself if this not resolved until next week to make a working patch again. I’ll keep you posted.

@schlagmichdoch
Copy link
Owner

You can confirm that this is indeed solved in the underlying library on this demo page:
https://strukturag.github.io/libheif/

@dm82m
Copy link
Author

dm82m commented Oct 16, 2024

You can confirm that this is indeed solved in the underlying library on this demo page: https://strukturag.github.io/libheif/

yes, it works there. so just waiting for a fix in pairdrop, but its not super urgent for me.

@schlagmichdoch schlagmichdoch linked a pull request Nov 11, 2024 that will close this issue
@schlagmichdoch
Copy link
Owner

Thanks for your patience!

I have since implemented this into a test instance. Please verify that everything works for you on this instance: https://pairdrop-next.onrender.com/ before I deploy this as part of the new version!

@dm82m
Copy link
Author

dm82m commented Nov 12, 2024

yes it works, tested the current version -> not working, tested this version here -> working! please let me know when it is deployed to public! and thanks for your work!

@dm82m
Copy link
Author

dm82m commented Dec 14, 2024

@schlagmichdoch when will it be deployed to production?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transfer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants