Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unable to send certain file #332

Open
terrytw opened this issue Sep 8, 2024 · 3 comments
Open

[Bug] Unable to send certain file #332

terrytw opened this issue Sep 8, 2024 · 3 comments
Labels
bug Something isn't working transfer UI/UX

Comments

@terrytw
Copy link

terrytw commented Sep 8, 2024

Describe the bug
I cannot send this file, every time I send it, the other device just disappears.

To Reproduce
1.zip
Please uncompress this zip file, and try sending the png file within.

Desktop (please complete the following information):

  • OS: [Windows]
  • Browser [chrome]
  • Version [Windows 10 22H2]

Smartphone (please complete the following information):

  • Device: [Android]
  • OS: [Android 12]
  • Browser [Kiwi browser, Pairdrop Android client]
  • Version [chromium 124]

Bug occurs on official PairDrop instance https://pairdrop.net/
Yes, and on dev.pairdrop.net

Bug occurs on self-hosted PairDrop instance
Yes

Self-Hosted Setup
Proxy: Caddy
Deployment:

docker run -d \
  --restart unless-stopped \
  --name=pairdrop \
  --hostname pairdrop \
  --net custom --ip ****** \
  -e PUID=1026 \
  -e PGID=101 \
  -e TZ=******* \
  -e RATE_LIMIT=true \
  -e WS_FALLBACK=true \
  -e RTC_CONFIG="/home/node/app/rtc_config.json" \
  -v /*****/docker/pairdrop/rtc_config.json:/home/node/app/rtc_config.json  \
  ghcr.io/schlagmichdoch/pairdrop

Version: v1.10.10

@terrytw terrytw added the bug Something isn't working label Sep 8, 2024
@schlagmichdoch
Copy link
Owner

I can reproduce this with the file when sending from iOS. Does this happen for you on Android only or also when sending the file from Windows?

The preview code needs to be rewritten and errors need to be catched properly. Sorry for the inconvenience.

@terrytw
Copy link
Author

terrytw commented Sep 10, 2024

I tried Windows to Windows and Windows to Android, both failed.

My rudimentary guess is that when sending pictures, pairdrop seems to render a preview/thumbnail, but my picture's aspect ratio is too extreme so it didn't work.

@schlagmichdoch
Copy link
Owner

That’s probably indeed what’s going on as it is going through fine when we bypass the thumbnail creation by changing the extension of the file from .png to .txt.

Anyways, I thought such errors would be catched and the file would then simply be sent without any thumbnail. I have to look into it to know more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transfer UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants