Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Downscale PDF asset for Schibsted logo #300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vmagaziy
Copy link

Having the mentioned PDF asset in its original size (1698×355) may cause performance issues when the login dialog is interactively dismissed in iOS 13 because the asset is too large.

ezgif-6-e909bc084ad5

This PR decreases dimensions of the asset to 149 × 31 while aspect ratio is maintained:

1698 / 355 = 4.783
149 / 31 = 4.806

@vmagaziy vmagaziy requested a review from sa-mao as a code owner March 29, 2020 13:01
@minarikg
Copy link
Collaborator

@vmagaziy

  • I’m wondering why is it rendereded multiple times during dismiss animation.
  • Did you preserv the PDF as a vector image?

@clausjoergensen
Copy link
Contributor

  • Did you preserv the PDF as a vector image?

This is not a 3rd party view, it's the IdentifierViewController.xib using the asset from the Images.xcassets, and no, it is not being preserved as vector data.

But the size is still absurd compared to the render size, using a smaller asset is better in every way possible. Smaller size footprint, less memory usage, smoother animations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants