Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external links in the sidebar #59

Closed

Conversation

HuidaeCho
Copy link

This PR fixes external links starting with https:// in the sidebar.

@schettino72
Copy link
Owner

uhmmm. not sure about this. The whole point of using pathto is to let sphinx handle that. Are you sure there is no configuration to control that?

can you show a sample code to reproduce the problem?

@HuidaeCho
Copy link
Author

can you show a sample code to reproduce the problem?

Sure. Please try this: https://github.com/HuidaeCho/projpicker/blob/main/docs/source/getting_started/index.rst

or https://github.com/HuidaeCho/projpicker/blob/main/docs/ if you need the entire documentation.

@HuidaeCho
Copy link
Author

HuidaeCho commented Jun 17, 2021

Checking https://www.sphinx-doc.org/en/master/templating.html, pathto() is for internal links only, I think. I think there must be a better and cleaner solution. The sphinx_rtd_theme doesn't have this problem.

pathto(document) Return the path to a Sphinx document as a URL. Use this to refer to built documents.

@schettino72
Copy link
Owner

fixed on 3bf0ba2

I did the check similar to what pathto and put that logic on python code. Instead of templates.
Thanks for the report and patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants