Skip to content

More SRFI tool patches #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 23, 2022
Merged

More SRFI tool patches #35

merged 4 commits into from
Oct 23, 2022

Conversation

lassik
Copy link
Contributor

@lassik lassik commented Oct 23, 2022

No description provided.

lassik added 4 commits October 23, 2022 10:30
@lassik
Export every from SRFI 1
0470a90
@lassik
Try to fix the string library mess
6a02ea3 
by providing a subset of the SRFI 13 API, source from either SRFI 13
itself or from SRFI 130. The latter uses string cursors, which we turn
into the ordinary integer indexes that are used with SRFI 13.
@lassik
Fix bug in generate-chart
4365797
@lassik
Avoid direct import of SRFIs in chart library
503fb94 
Use the wrapper libraries in private/ instead.
@lassik
Copy link
Contributor Author

lassik commented Oct 23, 2022

Can you check that srfi generate-chart still produces correct results? I'm not fully confident that I didn't break anything.

When I run it, I get a srfi.svg that looks visually sane. But in the SVG markup, every <path> element is different from the chart committed to git. The differences all seem to be in the fractional part of the coordinates, so ought to be no biggie. But I wonder how different versions of gnuplot (or running gnuplot on a different computer) can change them. Don't all desktop computers use IEEE floats?

@arthurgleckler arthurgleckler merged commit 00b7e06 into scheme-requests-for-implementation:master Oct 23, 2022
@arthurgleckler
Copy link
Contributor

Merged and pushed.

@lassik lassik deleted the patches branch October 23, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lassik @arthurgleckler