Skip to content

fix: Excessive reference inlining in large schemas #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2020

Conversation

Stranger6667
Copy link
Member

@Stranger6667 Stranger6667 commented Dec 25, 2020

Fixes #945

@codecov-io
Copy link

codecov-io commented Dec 25, 2020

Codecov Report

Merging #946 (94be3eb) into master (2ca9f50) will decrease coverage by 0.26%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
- Coverage   99.77%   99.50%   -0.27%     
==========================================
  Files          66       66              
  Lines        4465     4485      +20     
  Branches      735      739       +4     
==========================================
+ Hits         4455     4463       +8     
- Misses          3       12       +9     
- Partials        7       10       +3     
Flag Coverage Δ
unittests 99.50% <83.33%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/schemathesis/runner/impl/core.py 97.39% <25.00%> (-1.29%) ⬇️
src/schemathesis/extra/pytest_plugin.py 96.59% <66.66%> (-3.41%) ⬇️
src/schemathesis/schemas.py 100.00% <100.00%> (ø)
src/schemathesis/specs/openapi/_hypothesis.py 100.00% <100.00%> (ø)
src/schemathesis/specs/openapi/schemas.py 100.00% <100.00%> (ø)
src/schemathesis/cli/callbacks.py 98.19% <0.00%> (-1.81%) ⬇️
src/schemathesis/utils.py 98.37% <0.00%> (-1.63%) ⬇️
src/schemathesis/cli/__init__.py 98.83% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ca9f50...94be3eb. Read the comment docs.

@Stranger6667 Stranger6667 force-pushed the dd/performance-for-large-schemas branch from 94be3eb to 46f4eeb Compare December 25, 2020 13:50
@Stranger6667 Stranger6667 merged commit 152ccb8 into master Dec 25, 2020
@Stranger6667 Stranger6667 deleted the dd/performance-for-large-schemas branch December 25, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schemathesis stuck on large schemas
2 participants