-
Notifications
You must be signed in to change notification settings - Fork 6
Description
Hi community! Our team just found a possible security issue when reading the code. We would like to discuss whether it is a real vulnerability.
Description
The bug is that the StatefulSet schemahero in the charts has too much RBAC permission than it needs, which may cause some security problems, and the worse one leads cluster being hijacked. The problem is that the schemahero doesn't specify a ServiceAccount, so it uses the default ServiceAccount, which is bound to a clusterrole(cluster-role.yaml#L4) with the following sensitive permissions:
create/patch/updateverb of thedeploymentsresource (ClusterRole)patchverb of thestatefulsetsresource (ClusterRole)
After reading the source code of schemahero, I didn't find any Kubernetes API usages using these permissions. However, these unused permissions may have some potential risks:
create/patch/updateverb of thedeploymentsresource- A malicious user can create a privileged container with a malicious container image capable of container escape. This would allow him/she gaining ROOT privilege of the worker node the created container deployed. Since the malicious user can control the pod scheduling parameters (e.g., replicas number, node affinity, …), he/she should be able to deploy the malicious container to every (or almost every) worker node. This means the malicious user will be able to control every (or almost every) worker node in the cluster.
- The other permissions of
deployments/statefulsetsalso share the same risks.
The malicious users only need to get the service account token to perform the above attacks. There are several ways have already been reported in the real world to achieve this:
- Supply chain attacks: Like the xz backdoor in the recent. The attacker only needs to read
/var/run/secrets/kubernetes.io/serviceaccount/token. - RCE vulnerability in the APP: Any remote-code-execution vulnerability that can read local files can achieve this.
Mitigation Suggestion
- Remove all the unnecessary permissions
- Write Kyverno or OPA/Gatekeeper policy to:
- Limit the container image, entrypoint and commands of newly created pods. This would effectively avoid the creation of malicious containers.
- Restrict the
securityContextof newly created pods, especially enforcing thesecurityContext.privilegedandsecurityContext.allowPrivilegeEscalationtofalse. This would prevent the attacker from escaping the malicious container. In old Kubernetes versions,PodSecurityPolicycan also be used to achive this (it is deprecated in v1.21).
Few Questions
- Are these permissions really unused for schemahero?
- Would these mitigation suggestions be applicable for the schemahero?
- Our team have also found other unneccessary permissions (which is not that sensitive as above, but could also cause some security issues). Please tell us if you are interested in it. We’ll be happy to share it or PR a fix.
References
Several CVEs had already been assigned in other projects for similar issues: