-
Notifications
You must be signed in to change notification settings - Fork 20
Eyetracking utilization #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # build.gradle.kts # gradle/wrapper/gradle-wrapper.jar # gradle/wrapper/gradle-wrapper.properties # settings.gradle.kts
Just checking how you're doing on this @smlpt! It looks pretty merge friendly, but I'm curious if there is anything else you need on the sciview side? |
I am currently in the process of refactoring many of the tracking classes, because they were all created as command style classes, making it tedious to call them from code (I couldn't really call any member function except for So to answer your question: this branch turned into an active construction site again, and I may have to refine a few more things related to the tracking before we can merge it. I would also appreciate if this branch could be merged into scenery soon™, in case I need to add other stuff to scenery. |
This should now bring some order into the naming scheme. |
…creen on toggleVRRendering
I cleaned up the files, the PR is now ready for review. The CI fails because we can't use local scenery with it, and there's a scenery function that was updated in main and that didn't make it into a new release yet. |
Any progress on this? @kephale @skalarproduktraum |
@skalarproduktraum @kephale poke poke. The CI fails because we're missing a scenery version that contains a minor feature (message centering for the Camera class). |
@smlpt do you need that updated in |
I'm not working on this branch anymore, my latest changes are in the controller-tracking branch which I branched out from this one. But since that branch is also close to completion, I thought it makes sense to merge this one first. And I think @skalarproduktraum wanted this PR to be merged sometime. The branch works locally because I use a local scenery for it. My message was just to explain why the CI fails here. |
Aha, got it. Well just ping when you want the full review/merge! |
Would appreciate if this PR could be reviewed and merged to main @skalarproduktraum @kephale (whoever finds time first) |
Hi @smlpt! Happy to review, but in the current state, the CI doesn't run through with compilation errors. Please fix this, and then I'm more than happy to review and merge 🚢 |
Also happy to review and see this merged! If you ping when the CI is working I'll try to check it out asap |
@skalarproduktraum we will need a new scenery release then to fix the CI (see above comments) |
There are a few classes from Ruoshans original project that made their way into the PR and can maybe also be removed, but I'm not sure. At least they are not used for the current manvr3d features. These include:
|
Changes made by Ruoshan to implement a bridge for Mastodon tracking to Sciview, as well as utilize eye tracking in Sciview.