Skip to content

Radius tool #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Nov 5, 2025
Merged

Radius tool #26

merged 36 commits into from
Nov 5, 2025

Conversation

@smlpt
Copy link
Collaborator

@smlpt smlpt commented Jul 7, 2025 •
edited
Loading

This PR adds the following functionality:

  • resize the cursor by moving the right joystick up and down. Annotated and tracked spots will always inherit the cursor's size, relative to the volume's current size.
  • include cursor size in spot selections
  • when spots are selected: don't resize the cursor, instead resize the selected spots

smlpt added 18 commits May 16, 2025 10:44
@smlpt
SphereLinkNodes: add readlock while updating spots, add applyTagToAll…
8e84bfb 
…Spots method
@smlpt
SphereLinkNodes: add branch deletion via recursive search
8de2828
@smlpt
SphereLinkNodes: implement worker queue for sphere/link updates, add …
20be9e0 
…full time range prediction
@smlpt
SciviewBridgeUIMig: unify start/stop VR button
92070bd
@smlpt
Multi-spot selection and editing. Improved async worker queue
1a76ab4
@smlpt
SciviewBridge: fix timepoint wrapping
5998d80
@smlpt
SphereLinkNodes: allow selecting multiple points via drag. Update sel…
4e3982f 
…ection state selectively (not global)
@smlpt
SphereLinkNodes: clean up old unneeded code bits
f36b31d
@smlpt
SciviewBridge: always include whole time range for NN linking
1dfbb3b
@smlpt
Fix track merging behavior
7a9a92e
@smlpt
Fix edge polarity
2291e70
@smlpt
Fix spot radius sizes and updating
d878988
@smlpt
SciviewBridge: add sciviewToMastodonScale method
8780b73
@smlpt
SphereLinkNodes: pass radius from 3D cursor to Mastodon
0f7aeb8
@smlpt
SphereLinkNodes: added findSpotsInRange to do multi-spot selections
fffb8f1
@smlpt
Combine cursor and spot scaling behavior, wrapped by AnalogInputWrapper
2fc7089
@smlpt
Lower spot size adjustment speed, defer mastodon updates during drag …
3164265 
…behavior
@smlpt
SciviewBridge: add redo behavior
24f34a0
@smlpt smlpt linked an issue Jul 17, 2025 that may be closed by this pull request
Make spot scaling consistent between sciview and BDV #22
Closed
@smlpt smlpt mentioned this pull request Oct 23, 2025
Closed
@smlpt smlpt mentioned this pull request Oct 30, 2025
Merged
@smlpt
Merge branch 'main' into radius-tool
abc9b4d 
# Conflicts:
#	src/main/kotlin/SciviewBridge.kt
#	src/main/kotlin/SciviewBridgeUIMig.kt
#	src/main/kotlin/util/SphereLinkNodes.kt
@smlpt smlpt marked this pull request as ready for review October 30, 2025 13:46
@smlpt
Copy link
Collaborator Author

smlpt commented Oct 30, 2025

@skalarproduktraum I think we can also wrap this one up. All features here work, and I guess its better to not let this one grow too long either.

skalarproduktraum
skalarproduktraum requested changes Nov 5, 2025
View reviewed changes
Copy link
Member

@skalarproduktraum skalarproduktraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to fix, otherwise looks nice 👌

@smlpt smlpt merged commit 51c76ea into main Nov 5, 2025
@smlpt smlpt deleted the radius-tool branch November 5, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skalarproduktraum skalarproduktraum skalarproduktraum requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make spot scaling consistent between sciview and BDV

3 participants

@smlpt @skalarproduktraum