Add floatingPanel(_:contentOffsetForPinning:) delegate method #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
I'm considering whether the delegate name is appropriate or not. Please give me your advice if you have any ideas. |
The content offset preservation should be applied only when `FloatingPanelController.contentInsetAdjustmentBehavior` is `.always`. This is because the library user loses control of the initial offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FloatingPanelController asks the delegate for the content offset of a tracked scroll view pinned when a panel moves.
If you do not implement this method, the controller uses a value of the content offset plus the content insets. This method will not be called if the controller doesn't track any scroll view.
The reason why it's added is because a visual content origin of a scroll view is not always equal to its content offset plus its content insets. One of the cases is issue #304.
You can fix #304 by returning a value for a navigation bar with a large title as below.
See also "Show Navigation Controller" in the Samples app.