Fix logic check for UDP error, handle socket close #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeyus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix prevents
request_next_packet()being called when there is anasio::error::operation_abortedorasio::error::shut_down.previously, this would always return true even if the error was one of the above because of the or/
||There are also additional checks in the TCP/UDP server and stream outlet to (hopefully) more gracefully handle socket closure.
may address #199
I have experienced a segfault when switching networks on Windows and MacOS (I am primarily using Linux now but I haven't tried disconnecting an interface to see if it reproduces)