Minor changes to the Sweep library #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcyoung
requested changes
Aug 18, 2017
Added motor speed code for 0 Hz and corresponding entry in keywords.txt Changed 2 boolean functions (_writeCommand & _writeCommandWithArgument) which each had no return statement to void functions Fixed Sweep::getMotorReady() which had no return statement for the case where _readResponseInfoSetting() returns false
|
I have amended my commit to include the keyword for 0 Hz. |
|
@johnsonb2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed my previous commit and made a commit which does not include the raw angle changes but includes the other changes I made.
Scope of changes
Added motor speed code for 0 Hz
Changed 2 boolean functions (_writeCommand & _writeCommandWithArgument)
which each had no return statement to void functions
Fixed Sweep::getMotorReady() which had no return statement for the case
where _readResponseInfoSetting() returns false
Known Limitations
Same as before