Skip to content

fix: ES-117 pipeline and pom.xml #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 23, 2025
Merged

fix: ES-117 pipeline and pom.xml #21

merged 8 commits into from
Jan 23, 2025

Conversation

@isasmendiagus
Copy link
Contributor

@isasmendiagus isasmendiagus commented Jan 21, 2025 •
edited
Loading

WHAT

CODE:

  • Explicit declares scope for dependencies in pom.xml with <scope>compile<scope>
  • Declares info.picocl:picocli with scope optional (won't be included when imported)
  • Declares org.slf4j:slf4j-simple with scope runtime
  • Remove target scanoss-0.x.x-with-dependencies-exclude-slf4j from pom.xml

WORKFLOW

  • Fix artifacts name collision
  • Remove external dependency softprops/action-gh-release
  • Use official GH CLI to create release

@isasmendiagus isasmendiagus requested a review from eeisegn January 21, 2025 16:43
@isasmendiagus isasmendiagus merged commit b850cdd into main Jan 23, 2025
1 check passed
@isasmendiagus isasmendiagus deleted the fix/pipeline-and-pom-xml branch January 23, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eeisegn eeisegn eeisegn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isasmendiagus @eeisegn @ortizjeronimo