chore: refactor AbstractProduct preference#304
Open
robaimes wants to merge 1 commit intoscandiweb:mainfrom
Open
chore: refactor AbstractProduct preference#304robaimes wants to merge 1 commit intoscandiweb:mainfrom
robaimes wants to merge 1 commit intoscandiweb:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Thank you for contributing to the Satoshi Theme! Please provide the following information about your changes:
Summary
The block with name
product_list_itemhad its class changed.Satoshi uses a preference on the AbstractBlock class. Classes that extend a class that has been preferenced do not inherit the preference class, they still extend the original. Therefore the new View class calls the original getProductDetailsHtml method, rather than the Satoshi preference method.
I've replaced this preference with a ViewModel. Using a preference to change the method signature is rather abusive.
Type of Change
Please check the relevant option:
Related Issues
Changes Made
Testing
Please describe how you tested your changes:
Test Environment
Magento Version:
2.4.8-p3Hyva Theme Version:
1.4.3PHP Version:
8.4.14Testing Browsers: Chrome
Screenshots/Videos
If applicable, add screenshots or videos demonstrating the changes.
Performance Impact
Documentation
Checklist
Please confirm you have completed the following:
Additional Notes
Add any additional context, concerns, or questions about this PR.