-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSET-4359: Fix flaky tests #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdaratom-s1
approved these changes
Jul 27, 2023
https://github.com/scalyr/dataset-go/actions/runs/5692888480/job/15430824219?pr=46#step:10:297
|
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 75.36% 75.95% +0.60%
==========================================
Files 11 11
Lines 1534 1572 +38
==========================================
+ Hits 1156 1194 +38
+ Misses 315 314 -1
- Partials 63 64 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have introduced
RetryShutdownTimeout
in the PR #44, we have introduced a bug where if the value is set to 0, then it retries indefinitely - https://pkg.go.dev/github.com/cenkalti/backoff/v4#ExponentialBackOff.The test
add_events_long_running_test.go
was flaky, because its as called shutdown immediately after all the events has been submitted asynchronously. There was not enough time to process them and therefore they have been failing.This PR is also increasing version to 0.12.0