Update workflows to use "concurrency" GHA functionality to skip redundant workflow runs #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also pushed some changes which will hopefully make Since alert evaluation and alert state reporting only happens every 1 minute, it means we need to wait at least 2-3 minutes after creating an alert input before checking for results otherwise there is a high chance of a failure. It's worth noting that Playwright level retry won't do nothing in this situation since it simply retries the whole test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates GHA workflow to utilize "concurrency" functionality so we skip / cancel redundant build runs for non-main branch workflow runs.
Relying on this native functionality instead of on
skip-duplicate-jobsalso allows to to reduce permissions we need for workflow runs.