[DPDV-3497] Upgrade splunk-appinspect to the latest stable version, fix lint #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Playwright tests are failing, but I don't think it's related to any of my changes since I see they are also failing in other branches (https://github.com/scalyr/dataset-addon-for-splunk/actions/workflows/playwright.yml) - likely flaky / non-reliable test or similar. |
tomaz-s1
changed the title
Contributor
Author
|
OK, I think I see the reason why the tests are failing - it's related to the rename and some elements text changing. I will try to fix failing e2e tests as well. |
tomaz-s1
changed the title
Contributor
Author
|
The following PRs broke end to end tests:
I decided to merge this PR as-is (only update dependencies) and then handle fixing end to end tests as part of a separate PR. This means e2e tests will continue to fail until those have been fixed in the future PR. |
tomaz-s1
changed the title
tomaz-s1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates
splunk-appinspectto the latest stable version (v2.37.2) which includes latest fixes.Keep in mind that this release doesn't include a fix for pillow CVE yet, since it still depends on
pillow==9.5.0.Changelog file: https://dev.splunk.com/enterprise/docs/relnotes/relnotes-appinspectcli/whatsnew/#v23722023-09-14