Skip to content

Conversation

@martin-majlis-s1
Copy link
Collaborator

@martin-majlis-s1 martin-majlis-s1 commented Aug 14, 2023

Jira Link: https://sentinelone.atlassian.net/browse/DPDV-2608

🥅 Goal

For some compatibility reasons we want to introduce s1query alias.

🛠️ Solution

  1. Introduce alias for the autocomplete - https://docs.splunk.com/Documentation/Splunk/9.1.0/Admin/Searchbnfconf
  2. Introduce new command - https://docs.splunk.com/Documentation/Splunk/9.1.0/Admin/Commandsconf

🏫 Testing

  • I have introduced new test for search page - npx playwright test --headed e2e/search.spec.ts
  • I have tested it manually - | s1query maxcount=8 -
Screenshot 2023-08-15 at 10 02 40

@martin-majlis-s1
Copy link
Collaborator Author

Although the alias is being recommended, it cannot be used. :/

Screenshot 2023-08-14 at 14 05 51 Screenshot 2023-08-14 at 14 06 54

@zdaratom-s1
Copy link
Collaborator

@martin-majlis-s1
Copy link
Collaborator Author

Thanks. :) I was planning to search for the cause. :)

Copy link
Collaborator

@zdaratom-s1 zdaratom-s1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-majlis-s1 martin-majlis-s1 merged commit 20d6890 into main Aug 15, 2023
@martin-majlis-s1 martin-majlis-s1 deleted the DPDV-2608-introduce-alias branch August 15, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants