Skip to content

Conversation

@martin-majlis-s1
Copy link
Collaborator

To make development faster, lets introduce few makefile targets:

  • make pack - to pack the source code, you should run it after every change, so that you can test it
  • make docker-start - runs splunk with the application installed
  • make docker-restart - if you change some metadata, you should restart it
  • make docker-bash - execute bash inside docker container
  • make docker-tail-logs - to see logs

Copy link
Collaborator

@zdaratom-s1 zdaratom-s1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho there is inconsistency

sequence of
docker-splunk-start
docker-splunk-stop
docker-splunk-start will fail since stop stops only splunk while start starts docker it self (it will be still running)

@martin-majlis-s1
Copy link
Collaborator Author

imho there is inconsistency

sequence of docker-splunk-start docker-splunk-stop docker-splunk-start will fail since stop stops only splunk while strat starts docker it self

I am aware of this. They are on several levels:

  • docker commands - docker run splunk vs docker start splunk
  • manipulation with splunk inside - docker exec splunk splunk stop vs docker exec splunk splunk restart

So:

  • start - has to start docker container and start splunk inside
  • stop - it could be stopping container - docker stop splunk or stopping splunk - docker exec splunk splunk stop

So, to have your functionality, all the commands would have to manipulate only with the containers and not with the splunk inside

@martin-majlis-s1 martin-majlis-s1 added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit 82bdd20 Aug 3, 2023
@martin-majlis-s1 martin-majlis-s1 deleted the add-support-infrastructure branch August 3, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants