-
Notifications
You must be signed in to change notification settings - Fork 6
Add Makefile targets for make development simpler #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Tomáš Žďára <tomas.zdara@sentinelone.com>
Co-authored-by: Tomáš Žďára <tomas.zdara@sentinelone.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho there is inconsistency
sequence of
docker-splunk-start
docker-splunk-stop
docker-splunk-start will fail since stop stops only splunk while start starts docker it self (it will be still running)
I am aware of this. They are on several levels:
So:
So, to have your functionality, all the commands would have to manipulate only with the containers and not with the splunk inside |
To make development faster, lets introduce few makefile targets:
make pack- to pack the source code, you should run it after every change, so that you can test itmake docker-start- runs splunk with the application installedmake docker-restart- if you change some metadata, you should restart itmake docker-bash- execute bash inside docker containermake docker-tail-logs- to see logs